Quantcast
Channel: sshnet Issue Tracker Rss Feed
Viewing all articles
Browse latest Browse all 1026

Edited Task: Disable logging of messages in release builds [1767]

$
0
0
[Release 2013.4.7]
In the file Session.cs there are the lines:

[664] this.Log(string.Format("SendMessage to server '{0}': '{1}'.", message.GetType().Name, message.ToString()));

[1542] this.Log(string.Format("ReceiveMessage from server: '{0}': '{1}'.", message.GetType().Name, message.ToString()));

These lines are additions from the previous release where they were commented out.

Under testing I have found that when writing data there is approximately a 50% performance degredation, ie. in my test, the previous software release (without these logging statements), managed a transfer rate of approximately 700Kbps which degraded to approximately 300Kbps with the logging statements added in.

I have only tested write performance, but I have double-checked that the cause of the performance degredation is definitely due to the logging statements. Currently I have them both disabled in my local copy.

Can I suggest that these statements are temporarily removed?

Thank you.
Comments: ** Comment from web user: drieseng **

Logging of sent and received SSH messages is now disabled in release builds.


Viewing all articles
Browse latest Browse all 1026

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>