Quantcast
Channel: sshnet Issue Tracker Rss Feed
Viewing all articles
Browse latest Browse all 1026

Commented Unassigned: Infinite loop in SocketReadLine Method [1582]

$
0
0
First of all you are doing a great job, Thank's for that.
Where was an infinite loop ,do {..} while {.. buffer[buffer.Count - 1] == 0x0A ...} condition wasn't true, and a i get exception SshOperationTimeoutException("Socket read operation has timed out"), that was strange, i changed condition to
while (!(buffer.Count > 0 && (buffer[buffer.Count - 1].Equals(0x0A) || buffer[buffer.Count - 1].Equals(0x00) )));
and now everything works great. Thank one more time for your library.

also look at ConnectHttp Method
condition HttpStatusCode.OK

switch (statusCode)

case HttpStatusCode.OK:
break;
default:
throw new ProxyException(string.Format("HTTP: Status code {0}, \"{1}\" . {2}", statusCode, statusCode, response));

doesn't break a loop i think you should use a return clause;
Comments: ** Comment from web user: olegkap **

Hi,

Thanks for pointing out HttpStatusCode.OK issue, I just committed fix for that.
One thing I am not sure what is a difference between:
buffer[buffer.Count - 1] == 0x0A
and
buffer[buffer.Count - 1].Equals(0x0A)

Thanks,
Oleg


Viewing all articles
Browse latest Browse all 1026

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>